Fix #484, #447 #503
Closed
Fix #484, #447 #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In TargetManager, getTargets, and by extension fillTargets, has an implicit requirement that pathTarget.targets is not empty. If it is we re-call refreshTargets which would end up with infinite recursion. We have enough information to retrace the steps fillTargets currently takes so we can just set them ourselves
|
I'm sorry for being so slow to reply to this. What would really help is if we could add a spec, so we can guarantee it doesn't reappear. Regarding the code itself. I think it would make more sense to pass a Doing it like this and we'd avoid duplicating the |
noseglid
added a commit
that referenced
this pull request
May 22, 2017
Thanks to @sphaerophoria for correctly identifying the issue and providing an initial solution in #503. Fixes: #484, #447
noseglid
added a commit
that referenced
this pull request
May 22, 2017
Thanks to @sphaerophoria for correctly identifying the issue and providing an initial solution in #503. Fixes: #484, #447
Merged
|
Commited this in #520 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TargetManager, getTargets, and by extension fillTargets, has an
implicit requirement that pathTarget.targets is not empty. If it is we
re-call refreshTargets which would end up with infinite recursion. We
have enough information to retrace the steps fillTargets currently takes so
we can just set them ourselves.
There are three failing tests with my current implementation, however these three tests were failing before I made any changes.